Not creating customer number if at least 1 product is external

This commit is contained in:
Frank Schubert
2024-08-01 21:51:21 +02:00
parent ef3af99ae4
commit 35a1164da7

View File

@@ -1050,29 +1050,30 @@ class OrderController extends mfBaseController {
$ext_products_nbe += $product_data["price_nbe"];
} else {
$int_products = true;
if(!$owner->customer_number) {
$last_num = AddressModel::getLastCustomerNumber();
$this->log->debug("last_num: $last_num");
if($last_num) {
$new_num = $last_num + 1;
} else {
$new_num = TT_FIRST_CUSTNUM;
}
if(!AddressModel::search(['customer_number' => $new_num])) {
$owner->customer_number = $new_num;
$owner->save();
}
}
}
}
// generate and send Service PIN, only if:
// - owner does not have a Service PIN yet
// - there are no external products
// - owner_id was not set before or owner_id wasn't changed
if(!$ext_products && !$owner->customer_number) {
$last_num = AddressModel::getLastCustomerNumber();
$this->log->debug("last_num: $last_num");
if($last_num) {
$new_num = $last_num + 1;
} else {
$new_num = TT_FIRST_CUSTNUM;
}
if(!AddressModel::search(['customer_number' => $new_num])) {
$owner->customer_number = $new_num;
$owner->save();
}
}
// generate and send Service PIN, only if:
// - owner does not have a Service PIN yet
// - there are no external products
// - owner_id was not set before or owner_id wasn't changed
// TODO: move this to Order class
if(!$ext_products && !$owner->spin && (!property_exists($order->_old_data, "owner_id") || $order->owner_id == $order->_old_data->owner_id)) {
$this->log->debug(__CLASS__."::save(): creating new SPIN for ".$owner->getCompanyOrName()." (".$owner->id.")");