From 603bfa0f157ac072df669ef48fc8bd82eda90164 Mon Sep 17 00:00:00 2001 From: Frank Schubert Date: Thu, 15 Jan 2026 15:53:46 +0100 Subject: [PATCH] Changed status change to single call in Preorder/Cif api --- application/Api/v1/Modules/Preorder/Cif.php | 36 +++------------------ 1 file changed, 4 insertions(+), 32 deletions(-) diff --git a/application/Api/v1/Modules/Preorder/Cif.php b/application/Api/v1/Modules/Preorder/Cif.php index 8e60be040..6a34e818f 100644 --- a/application/Api/v1/Modules/Preorder/Cif.php +++ b/application/Api/v1/Modules/Preorder/Cif.php @@ -43,22 +43,8 @@ class Cif extends Modules\ApiControllerModule { return \mfResponse::NotFound(["message" => "Preorder not found"]); } - // set status to 200 - if($preorder->status->code < 200) { - $new_status = \PreorderstatusModel::getFirst(["code" => 200]); - if(!$new_status) { - return \mfResponse::InternalServerError(); - } - $preorder->status_id = $new_status->id; - $preorder->save(); - } - - $sflag = \PreorderStatusflagModel::getFirst(["code" => 200]); - $sflag->preorder_id = $preorder->id; - if(!$sflag->value->value) { - $sflag->value->value = 1; - $sflag->value->save(); - } + // set status flag 200 + $preorder->setStatusFlag(200, 1); return \mfResponse::Ok(["message" => "Status successfully updated."]); @@ -134,22 +120,8 @@ class Cif extends Modules\ApiControllerModule { return \mfResponse::NotFound(["message" => "Invalid ciftoken"]); } - // set status to 200 - if($preorder->status->code < 200) { - $new_status = \PreorderstatusModel::getFirst(["code" => 200]); - if(!$new_status) { - return \mfResponse::InternalServerError(); - } - $preorder->status_id = $new_status->id; - $preorder->save(); - } - - $sflag = \PreorderStatusflagModel::getFirst(["code" => 200]); - $sflag->preorder_id = $preorder->id; - if(!$sflag->value->value) { - $sflag->value->value = 1; - $sflag->value->save(); - } + // set status flag 200 + $preorder->setStatusFlag(200, 1); return \mfResponse::Ok(["message" => "Status successfully updated."]);