Changed permission checks in Order form items

application/Order/OrderController.php

@@ -50,34 +50,23 @@ class OrderController extends mfBaseController {
       $this->layout()->set("products", ProductModel::getAll());
       $this->layout()->set("terminations", TerminationModel::getAll());
     } else {
-      // get all addresses of my networks
+      // get all salespartner addresses of my networks
       $network_ids = [];
       $addresses = [];
+      
+      // get users from salespartner addresses of my networks
+      $users = [];
       foreach($this->me->my_networks as $network) {
         $network_ids[] = $network->id;
-        foreach(AddressModel::byNetwork($network->id, "salespartner") as $address) {
-          if(!array_key_exists($address->id, $addresses)) {
-            $addresses[] = $address;
+        $tmp_users = $network->getAddressUsersByAddresstype("salespartner");
+        foreach($tmp_users as $user) {
+          if(!in_array($user->id, $users)) {
+            $users[] = $user->id;
           }
         }
       }
-      
-      $users = [];
-      $user_ids = [];
-      foreach($addresses as $address) {
-        $address_id = $address->id;
-        if($address->parent_id) {
-          $address_id = $address->parent_id;
-        }
-        foreach(UserModel::search(['address_id' => $address_id]) as $user) {
-          if(!array_key_exists($user->id, $users)) {
-            $users[$user->id] = $user;
-            $user_ids[] = $user->id;
-          }
-        }
-      }
-
-      $addresses = AddressModel::search(['create_by' => $user_ids]);
+      // get addresses from salespartner address' user ids
+      $addresses = AddressModel::search(["create_by" => $users]);
       $this->layout()->set("addresses", $addresses);
       
       // get terminations in my networks
@@ -88,7 +77,7 @@ class OrderController extends mfBaseController {
       $products = [];
       foreach(ProductNetworkModel::search(["network_id" => $network_ids]) as $pn) {
         if(!array_key_exists($pn->product_id, $products))
-        $products[$pn->product_id] = $pn->product;
+          $products[$pn->product_id] = $pn->product;
       }
       $this->layout()->set("products", $products);